RobertSkalko / Mine-And-Slash-Rework

Mine and Slash Minecraft Mod
https://www.curseforge.com/minecraft/mc-mods/mine-and-slash-reloaded
21 stars 25 forks source link

[Bug]: Default "datapack" causing errors. #145

Closed zerafox closed 15 hours ago

zerafox commented 1 day ago

Describe the bug you're experiencing

I've updated Mine and Slash to it's currently latest version: 5.9.9 When I login to the game I get a notice in chat about how there are errors with my Mine and Slash datapacks, some things may break.

Here is the errors the logs produced:`[14:50:27] [Render thread/WARN]: ============[Mine and Slash Datapack Check Failed]================= [14:50:27] [Render thread/WARN]: The file with id epic is different after loading [14:50:27] [Render thread/WARN]: Json from your datapack:

[14:50:27] [Render thread/WARN]: Json after it was loaded and turned back into json:

[14:50:27] [Render thread/WARN]: Please check for things like wrong field names, missing fields, wrong types used etc. [14:50:27] [Render thread/WARN]: You can copy and paste these jsons into any online Json Comparison/Diff tools see what the difference is. Like: www.jsondiff.com

[14:50:27] [Render thread/WARN]: ============[Mine and Slash Datapack Check Failed]================= [14:50:27] [Render thread/WARN]: The file with id uncommon is different after loading [14:50:27] [Render thread/WARN]: Json from your datapack:

[14:50:27] [Render thread/WARN]: Json after it was loaded and turned back into json:

[14:50:27] [Render thread/WARN]: Please check for things like wrong field names, missing fields, wrong types used etc. [14:50:27] [Render thread/WARN]: You can copy and paste these jsons into any online Json Comparison/Diff tools see what the difference is. Like: www.jsondiff.com

[14:50:27] [Render thread/WARN]: ============[Mine and Slash Datapack Check Failed]================= [14:50:27] [Render thread/WARN]: The file with id legendary is different after loading [14:50:27] [Render thread/WARN]: Json from your datapack:

[14:50:27] [Render thread/WARN]: Json after it was loaded and turned back into json:

[14:50:27] [Render thread/WARN]: Please check for things like wrong field names, missing fields, wrong types used etc. [14:50:27] [Render thread/WARN]: You can copy and paste these jsons into any online Json Comparison/Diff tools see what the difference is. Like: www.jsondiff.com

[14:50:27] [Render thread/WARN]: ============[Mine and Slash Datapack Check Failed]================= [14:50:27] [Render thread/WARN]: The file with id rare is different after loading [14:50:27] [Render thread/WARN]: Json from your datapack:

[14:50:27] [Render thread/WARN]: Json after it was loaded and turned back into json:

[14:50:27] [Render thread/WARN]: Please check for things like wrong field names, missing fields, wrong types used etc. [14:50:27] [Render thread/WARN]: You can copy and paste these jsons into any online Json Comparison/Diff tools see what the difference is. Like: www.jsondiff.com

[14:50:27] [Render thread/WARN]: ============[Mine and Slash Datapack Check Failed]================= [14:50:27] [Render thread/WARN]: The file with id mythic is different after loading [14:50:27] [Render thread/WARN]: Json from your datapack:

[14:50:27] [Render thread/WARN]: Json after it was loaded and turned back into json:

[14:50:27] [Render thread/WARN]: Please check for things like wrong field names, missing fields, wrong types used etc. [14:50:27] [Render thread/WARN]: You can copy and paste these jsons into any online Json Comparison/Diff tools see what the difference is. Like: www.jsondiff.com

[14:50:27] [Render thread/WARN]: ============[Mine and Slash Datapack Check Failed]================= [14:50:27] [Render thread/WARN]: The file with id unique is different after loading [14:50:27] [Render thread/WARN]: Json from your datapack:

[14:50:27] [Render thread/WARN]: Json after it was loaded and turned back into json:

[14:50:27] [Render thread/WARN]: Please check for things like wrong field names, missing fields, wrong types used etc. [14:50:27] [Render thread/WARN]: You can copy and paste these jsons into any online Json Comparison/Diff tools see what the difference is. Like: www.jsondiff.com

[14:50:27] [Render thread/WARN]: ============[Mine and Slash Datapack Check Failed]================= [14:50:27] [Render thread/WARN]: The file with id common is different after loading [14:50:27] [Render thread/WARN]: Json from your datapack:

[14:50:27] [Render thread/WARN]: Json after it was loaded and turned back into json:

[14:50:27] [Render thread/WARN]: Please check for things like wrong field names, missing fields, wrong types used etc. [14:50:27] [Render thread/WARN]: You can copy and paste these jsons into any online Json Comparison/Diff tools see what the difference is. Like: www.jsondiff.com

[14:50:27] [Render thread/WARN]: ============[Mine and Slash Datapack Check Failed]================= [14:50:27] [Render thread/WARN]: The file with id runeword is different after loading [14:50:27] [Render thread/WARN]: Json from your datapack:

[14:50:27] [Render thread/WARN]: Json after it was loaded and turned back into json:

[14:50:27] [Render thread/WARN]: Please check for things like wrong field names, missing fields, wrong types used etc. [14:50:27] [Render thread/WARN]: You can copy and paste these jsons into any online Json Comparison/Diff tools see what the difference is. Like: www.jsondiff.com

After some digging I found that these are files related to the new gear rarity datapacks added to the mod back in 5.9.0 No mod pack I use touches any of these values. So, I looked into the mod jar itself and found that these files actually still include the "vanilla_rar_enum": "UNCOMMON_ITEM", value that was said to be removed in 5.9.9. I was still getting errors when I attempted to downgrade my MnS to 5.9.0 but got similar notices and errors.

Reproducability

Install Mine and Slash 5.9.0+ (or) 5.9.9 first and load into a world. See chat based notice about datapack errors.

Mod up to date

Tested Without Custom Mine and Slash Datapacks

Mine and Slash version

5.9.9

Logs

https://gist.github.com/zerafox/a9607683141d70722c54382b087692ef

RobertSkalko commented 1 day ago

I probably forgot to run datagen before the update, woops

RobertSkalko commented 15 hours ago

Should be fixed