RobertSkalko / Mine-And-Slash-Rework

Mine and Slash Minecraft Mod
https://www.curseforge.com/minecraft/mc-mods/mine-and-slash-reloaded
18 stars 23 forks source link

Auto Salvage Bag not auto salvaging? #90

Closed SirMoogle closed 5 months ago

SirMoogle commented 5 months ago

Currently playing the Craft to Exile - Dissonance pack, and I crafted an Auto Salvage Bag. I set it to salvage common gear, but it still shows up in my inventory. Am I doing something wrong?

RobertSkalko commented 5 months ago

Equip it to curio slot irc

SirMoogle commented 5 months ago

Alright, I've equipped it to the curio slot. I think what I'm confused on is that it doesn't seem to salvage equipment that I find in chests or that I drop from my inventory, and where the salvaged materials go.

RobertSkalko commented 5 months ago

It salvages when you pick them up from the ground. The materials are probably in your master bag

SirMoogle commented 5 months ago

Played around a bit more and it seems that the exceptions it makes is gear that you'd normally find in vanilla, like helmets, chestpieces, leggings, and boots; vanilla swords also seem to be affected. Anyway to get those to automatically salvage or is that intended?

RobertSkalko commented 5 months ago

If the gear has no mine and slash stats it wont be salvaged

SirMoogle commented 5 months ago

The issue still persists after exiting and reopening the inventory so that the gear has stats. When I toss it and pick it up, it shows up again in my inventory.

RobertSkalko commented 5 months ago

The auto salvage is simple, if it's setup to salvage say common rarity, it will salvage any gear with mns stats that has common rarity, unless that item is enchanted. Closing as this isn't an issue and also not a latest version question

SirMoogle commented 5 months ago

Could you add documentation stating that for whichever version is on MC 1.15.2 that enchanted items don't get salvaged? Nowhere in either repository is this mentioned.