cad2cd2 - This is updating Patchouli as you were outdated anyway. The build included in libs is just Patchouli with updated mappings from this pull request. Tested the book in dev and it works fine. I built and tested the mod in my normal forge install with the Patchouli straight from CurseForge and found no errors building the book or reading it.
d2b2847 - This is updating the mappings to stable_39, most of the changes are updating setUnlocalizedName to setTranslationKey. I have tested nearly everything I can think of and can find bugs being created by doing this. You can further test this if you'd like. I checked this method changes by checking with the MCPBot, really cool tool btw.
I suggest running gradlew setupDecompWorkspace --refresh-dependencies if you do merge this, to get rid of the cached Patchouli you have in your gradle cache. If you have anymore questions regarding this PR, please let me know!
RobertSkalko
commented
5 years ago
cad2cd2 - This is updating Patchouli as you were outdated anyway. The build included in libs is just Patchouli with updated mappings from this pull request. Tested the book in dev and it works fine. I built and tested the mod in my normal forge install with the Patchouli straight from CurseForge and found no errors building the book or reading it.
d2b2847 - This is updating the mappings to stable_39, most of the changes are updating
setUnlocalizedNametosetTranslationKey. I have tested nearly everything I can think of and can find bugs being created by doing this. You can further test this if you'd like. I checked this method changes by checking with the MCPBot, really cool tool btw.I suggest running
gradlew setupDecompWorkspace --refresh-dependenciesif you do merge this, to get rid of the cached Patchouli you have in your gradle cache. If you have anymore questions regarding this PR, please let me know!