search

RobertSpread / spreadcart

simple plugin to display a cart for the spreadshop everywhere on your domain
1 stars 1 forks source link

Made JSON response handling more robust #36

Closed jtlapp closed 8 years ago

jtlapp commented 8 years ago

Modified to handle strange response from a PHP server reported in issue #35. responseJSON was not being set in the ajax response. I tried making the PHP response header JSON conformant, but that didn't help. So I'm reading data from the provided response handler, which I should have done to begin with. I also left the PHP proxy providing a correct response header, although I don't know that this made a difference.

This time I copied your files on top of mine, modified mine, and checked them in, and yet github still thinks I've dramatically changed everything.

RobertSpread commented 8 years ago

Can't get this done again ;( Checked with the developers and they also have no idea. Delete the repository and start over again?

RobertSpread commented 8 years ago

(BTW, sorry for my late replies and my missing support. I have some stuff to sort out right now.)

RobertSpread commented 8 years ago

So, I merged zour pull request via githubs desktop application. I have absolutely no clue if this fixed all issues. I will close this pull request and would like to ask you to check if everything works as expected (as I have no options to test node.js solutions right now. Maybe you can also try to add a comment and create a pull request in order to check if it now works.

Fingers crossed! ;)