search

RobertoPrevato / KingTable

Library for administrative tables that are able to build themselves, on the basis of the input data.
MIT License
68 stars 17 forks source link

Bugfix: Import of open-iconic symbols #11

Closed rickschubert closed 7 years ago

rickschubert commented 7 years ago

Hi Roberto,

First off, thank you very much for this awesome table, I like it a lot.

I was playing around with it a bit but experienced the issue that the symbols from open-iconic could not be displayed or loaded (I am using Windows 10 and Google Chrome, in case that matters). I found out that the issue was a wrong link/reference in kingtable.core.css.

Regards, Rick

RobertoPrevato commented 7 years ago

Hi Rick, Thanks for your kind words, I am glad you like my library. In these days, in the free time, I am working on support for grouping.

I cannot accept your pull request, because of two reasons: first, you edited the minified .css file for distribution, and this file is obtained from building and minifying the LESS source code; using the Gulp tasks defined in the repository (described here). One could argue that a built file should not be committed and pushed to a git repository, in the first place. But in practice and real life, not everybody knows how to use Node.js and npm, to build source code into files that can be used by browsers. In any case, source code (LESS) should be modified, not files built for distribution.

Secondly, the paths in my CSS are not broken: they simply require a server. They don't work when opening an html file from file system, but they do work when serving HTML using an HTTP server (which in production you always have, and in development too, since it's necessary to test AJAX requests). For example, my live demos hosted in GitHub work perfectly fine, because HTML is served by GitHub servers, and paths are similar.

rickschubert commented 7 years ago

Hi Roberto, thank you for the answer! 👍 I didn't realise that there were also README files in the source folder. Actually, I pretty much overlooked the source foulder at all 🤦‍♂️ Thanks! :)