search

RobertoPrevato / KingTable

Library for administrative tables that are able to build themselves, on the basis of the input data.
MIT License
68 stars 17 forks source link

Avoid treating Chinese character as Diacritics #5

Closed killuazhu closed 7 years ago

killuazhu commented 7 years ago

Chinese characters were treated as diacritics which would return wrongly highlighted string when searching Chinese character within string.

For example, search 日 within 2017年12月31日 would return 2017年12月31<span class="kt-search-highlight">日年日</span>.

This change utilize the existing normalize function to validate the found string is a valid diacritics.

RobertoPrevato commented 7 years ago

Hi @killuazhu, thank you for your contribution! I invited you as collaborator of the repository, if you'd like to join. Lately I didn't have time to dedicate on KingTable (only in GitHub, I worked on other things, for example a tutorial on how to use Python with MySQL and SQLAlchemy, here and a Python console application to do bulk-upload to Azure Blob Storage, here).

However, I am planning to write a table builder for use with React and maybe an example of integration with Azure Table service.

killuazhu commented 7 years ago

Hey Roberto, Thanks for the invitation. I don't mind accepting, but I doubt I would contribute too much. My friend @bohmwu likes KingTable and asked me to help him build a simple page (here) to visualize his data. Now the project is almost done, I would anticipate adding data be the main follow-ups. Thanks for good examples and dev server, I found it's quite straightforward to pick up KingTable and build something based on it immediately.