search

Robertscorp / Slender.Dependencies

A .NET library to register your project's dependencies without being tied to a specific dependency injection container.
MIT License
0 stars 0 forks source link

Rename some classes and improve XML comments to make it more self-explanatory #16

Closed Robertscorp closed 1 year ago

Robertscorp commented 1 year ago

Registration was ServiceRegistration, maybe make it "RegisteredService" RegistrationBuilder isn't technically a builder, but a proxy. RegisteredServiceProxy isn't very nice, maybe re-think this.

RegisteredService is a decent enough name for what it is. It's pretty much how the comments refer to the entity. RegisteredService and RegisteredServiceData?

Some of the XML comments just don't feel right after navigating the documentation. Just do general improvements as they come along.

Robertscorp commented 1 year ago

RegistrationCollection -> RegisteredServices

Is ConfigureService right? If we have AddService, should we have UpdateService?

Robertscorp commented 1 year ago

RegisteredServiceProxy isn't very nice, and Microsoft uses "Builder" for classes that configure (IControllerModelBuilder.ApplyTo), so it's probably not the end of the world to keep the "Builder" name.

That said, it isn't a builder, it's a proxy...

Robertscorp commented 1 year ago

Change Service -> Dependency? does that conflict with anything else...