search

RobinBlomberg / kysely-codegen

Generate Kysely type definitions from your database.
MIT License
690 stars 62 forks source link

Add a skip-domains flag for postgres #136

Closed RobinClowers closed 3 months ago

RobinClowers commented 4 months ago

Adds a new --skip-domains flag to skip domain introspection. This is useful for postgres compatible databases that don't support domains, like Materialize.

Fixes #112

I tried to follow the style in the project, and I ran the tests. Let me know if there is a better / different way to plumb the option through that you would prefer.

RobinClowers commented 3 months ago

@RobinBlomberg would love a review here when you have a chance!

RobinBlomberg commented 3 months ago

Hey! I'll look at this as soon as I have some time. Code looks good, but I'd probably rename "opts" to "options". But stay tuned.

RobinBlomberg commented 3 months ago

Awesome! Released in 0.14.0!

RobinClowers commented 3 months ago

Thank you!