search

RobinHankin / gsl

an R wrapper for the Gnu Scientific Library
15 stars 9 forks source link

configure.ac problem #16

Closed RobinHankin closed 2 years ago

RobinHankin commented 3 years ago

On submitting to CRAN, the package was accepted but the autocheck returned the following:

CRAN teams' auto-check service
Package check result: WARN

Check: CRAN incoming feasibility, Result: Note_to_CRAN_maintainers
  Maintainer: ‘Robin K. S. Hankin <hankin.robin@gmail.com>’

Check: top-level files, Result: WARNING
    Output from running autoreconf:
    configure.ac:58: warning: AC_OUTPUT should be used without arguments.
    configure.ac:58: You should run autoupdate.

No changes to worse in reverse depends.
RobinHankin commented 2 years ago

Kurt sends an email:

>>>>> Kurt Hornik writes:

I just put a fixed version on CRAN: pls merge with your master sources.

-k

> Dear maintainer,

> Please see the problems shown on
> <https://cran.r-project.org/web/checks/check_results_gsl.html>.

> The top-level files check problems on the Debian systems are from using
> Autoconf 2.71, for which warnings about obsolete constructs are now on
> by default.  The warnings can be reproduced and typically fixed using
> Autoconf 2.69.  For the latter,

>   autoupdate; autoreconf --warnings=obsolete

> "usually" works ...

> Please correct before 2021-10-31 to safely retain your package on CRAN.

> Best,
> -k
RobinHankin commented 2 years ago

For the record, the error messages given on CRAN are:

Version: 2.1-7
Check: top-level files
Result: WARN
     Output from running autoreconf:
     configure.ac:58: warning: AC_OUTPUT should be used without arguments.
     configure.ac:58: You should run autoupdate.
Flavors: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-patched-linux-x86_64, r-release-linux-x86_64

Version: 2.1-7
Check: top-level files
Result: WARN
     Output from running autoreconf:
     configure.ac:58: warning: AC_OUTPUT should be used without arguments.
     configure.ac:58: You should run autoupdate.
     configure.ac:58: warning: AC_OUTPUT should be used without arguments.
     configure.ac:58: You should run autoupdate.
Flavor: r-devel-linux-x86_64-fedora-clang

Version: 2.1-7
Check: whether package can be installed
Result: ERROR
    Installation failed.
Flavor: r-oldrel-windows-ix86+x86_64
RobinHankin commented 2 years ago

If I just copy Kurt's modified file, I must not forget to include 42b6d5c69867285e8557f5556be2f4de93ccb3ed which corrects a separate problem.

RobinHankin commented 2 years ago

fixed in a30ae86 and 8425db1

bastistician commented 2 years ago

If I just copy Kurt's modified file, I must not forget to include 42b6d5c which corrects a separate problem.

and also 0a5dd64e0c0b24dbfefa5af017d48c9af22424ca :)

RobinHankin commented 2 years ago

yes indeed! thanks