search

RobinHankin / mvp

https://robinhankin.github.io/mvp/
8 stars 3 forks source link

update for mpoly v1.1.0 #17

Closed dkahle closed 5 years ago

dkahle commented 5 years ago

This should fix the little bugs in mvp caused by the upgrading of mpoly to 1.1.0, although I'm not sure why things like 4x parsed properly before. In any case, please give it a look/check. From my side, R CMD check --as-cran mvp_1.0-5.tar.gz is clean. Thanks, Robin!

RobinHankin commented 5 years ago

David, thanks for this.

The changes to mvp look good to me. Frankly I am still getting used to github for collaborative work and I worry that I'm going to do something stupid; please bear with me.

Best wishes

Robin

hankin.robin@gmail.com hankin.robin@gmail.com

hankin.robin@gmail.com

hankin.robin@gmail.com

On Wed, Jan 30, 2019 at 10:58 AM david kahle notifications@github.com wrote:

This should fix the little bugs in mvp caused by the upgrading of mpoly to 1.1.0, although I'm not sure why things like 4x parsed properly before. In any case, please give it a look/check. From my side, R CMD check --as-cran mvp_1.0-5.tar.gz is clean. Thanks, Robin!

You can view, comment on, or merge this pull request online at:

https://github.com/RobinHankin/mvp/pull/17 Commit Summary

  • update for mpoly v1.1.0

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/RobinHankin/mvp/pull/17, or mute the thread https://github.com/notifications/unsubscribe-auth/AMpc0iOP5i7nmArN9CQwgjdYS5FW9Bzyks5vIMQFgaJpZM4aZBP9 .

dkahle commented 5 years ago

Hah! No problem; it's bewildering at first. You may find this helpful: https://happygitwithr.com; it's also hilarious. :)

If you'd like to Skype/appear.in sometime to run over the details, I'd be happy to take you through it.