search

RobinHankin / permutations

https://robinhankin.github.io/permutations/
5 stars 3 forks source link

removing importFrom directive for print.partition #24

Closed pegeler closed 3 years ago

pegeler commented 3 years ago

As discussed in RobinHankin/partitions#14, the importFrom("partitions", "print") NAMESPACE directive is not necessary here. It was enough when the S3 method print.partition was registered in the partitions package with the NAMESPACE directive S3method(print,partition). This is detailed in Writing R Extensions.

This PR takes care of that issue and also fixes a few other things that I found when running R CMD check.

codecov[bot] commented 3 years ago

Codecov Report

Merging #24 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   35.38%   35.38%           
=======================================
  Files           4        4           
  Lines         828      828           
=======================================
  Hits          293      293           
  Misses        535      535

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ed3a52d...48a3186. Read the comment docs.