search

RobinHankin / spray

sparse arrays and fast multivariate polynomials
https://robinhankin.github.io/spray/
2 stars 2 forks source link

CRAN imports problem #15

Closed RobinHankin closed 3 years ago

RobinHankin commented 3 years ago

Following email from Kurt, 17 September 2020 (elided):

Dear maintainers,

This concerns the CRAN packages

  ProbReco TBRDist TestDimorph TreeDist TreeTools amt
  economiccomplexity graph4lg inspector metan sortable spray spsur

maintained by one of you:

  Anastasios Panagiotelis <anastasios.panagiotelis@sydney.edu.au>:
        ProbReco
  Andrie de Vries <apdevries@gmail.com>: sortable
  Bassam A. Abulnoor <bas12@fayoum.edu.eg>: TestDimorph
  Johannes Signer <jsigner@gwdg.de>: amt
  Martin R. Smith <martin.smith@durham.ac.uk>: TBRDist TreeDist TreeTools
  Mauricio Vargas <mvargas@dcc.uchile.cl>: economiccomplexity
  Paul Savary <savarypaul660@gmail.com>: graph4lg
  Pedro Fonseca <pedro.teles.fonseca@phd.iseg.ulisboa.pt>: inspector
  Robin K. S. Hankin <hankin.robin@gmail.com>: spray
  Roman Minguez <roman.minguez@uclm.es>: spsur
  Tiago Olivoto <tiagoolivoto@gmail.com>: metan

These use the RdMacros mechanism and list the packages providing the Rd
macros in 'Suggests', with R-exts thus far suggesting to list in
'Imports' or 'Suggests' (or 'Depends').  However, as can be seen from
<https://cran.r-project.org/web/checks/check_results_inspector.html>,
installation warns if an "only suggested" RdMacros package is not
available at install time (justifiable, as when building static help
pages the macros are processed at install time).

Out of about 240 CRAN packages using the RdMacros mechanism, your
packages are the ones listing in 'Suggests', all the others use
'Imports'.  I just changed R-exts to say one should list in 'Imports'
(or 'Depends'): can you please change your package accordingly?

(Once the check code is changed accordingly, your packages will no
longer be installable.)

Please provide new versions with your RdMacros packages in Imports
instead of Suggests as quickly as possible, ideally within the next 2
weeks.

Best
-k
pegeler commented 3 years ago

I believe that this NOTE that I receive when running R CMD check is related to this issue as well as bc29795.

   Package in Depends field not imported from: ‘mathjaxr’
     These packages need to be imported from (in the NAMESPACE file)
     for when this namespace is loaded but not attached.

Recommendation

Move mathjaxr from Depends: to Import: and also add import(mathjaxr) into your NAMESPACE file.