RobinHankin / stokes

methods for exterior calculus
https://robinhankin.github.io/stokes/
3 stars 0 forks source link

stokes - spray interaction #53

Closed RobinHankin closed 2 years ago

RobinHankin commented 2 years ago

The CRAN version of stokes does not pass R CMD check with the latest version of spray:

https://github.com/RobinHankin/spray/issues/24

So what I am going to to is release a (very!) reduced functionality version of stokes, version 1.0-9, which works with both old and new versions of spray. That way, once stokes 1.0-9 is on CRAN I can upload the latest version of spray to CRAN, then upload a proper version of stokes.

The alternative (leaving stokes as it is) would not work: the new version of spray would fail revdep_check() and it would not be accepted on to CRAN.

I am not going to commit any of the code changes for stokes 1.0-9 to github as all the changes are just the removal of functionality.

RobinHankin commented 2 years ago

Just got an email from kurt saying stokes_1.0-9.tar.gz is on CRAN. I'll give it a couple of days then upload spray_1.0-16.tar.gz. Then I will be free to upload stokes_1.0-10.tar.gz. And when I do that I'll close this issue.

RobinHankin commented 2 years ago

https://github.com/RobinHankin/spray/commit/7e56f4adb75fc18a37919e88de37f77f64bbb91a

shows some stokes-spray interaction issues.

RobinHankin commented 2 years ago

spray 1.0-18 now on CRAN, as per tag https://github.com/RobinHankin/spray/releases/tag/1.0-18

RobinHankin commented 2 years ago

stokes 1.1-1 now on CRAN