RobinLu1209 / ST-GFSL

Apache License 2.0
40 stars 9 forks source link

Why add target dataset when construct the dataset? #2

Closed isharrisleung closed 2 years ago

isharrisleung commented 2 years ago

Hello author, thank you for your excellent work. I've been studying your work recently and I've run into some problems that I hope you can help me with. As I said in the title, why in the Meta-Train stage, when constructing the dataset, do you add the target data?

截屏2022-09-01 22 40 42

After doing this, when Meta-train reads the data, the target data will be randomly obtained, as follows:

截屏2022-09-01 22 43 20

I think it leads to the leakage of information of target data. Is my point correct? Or maybe I'm missing something and misunderstood your approach. Looking forward to your answer, thank you very much.

RobinLu1209 commented 2 years ago

Hello, thank you for your attention to our work! First of all, I want to stress that there is no data leakage problem here. "add_target" is an optional parameter. When it is TRUE, we will only add the few-shot training data in target city (for example, 3-day data for fine-tuning). The specific code is in dataset.py Lines 83 to 107. Therefore, the test data or large scale training data of the target city will not be involved.

isharrisleung commented 2 years ago

Hello, thank you for your attention to our work! First of all, I want to stress that there is no data leakage problem here. "add_target" is an optional parameter. When it is TRUE, we will only add the few-shot training data in target city (for example, 3-day data for fine-tuning). The specific code is in dataset.py Lines 83 to 107. Therefore, the test data or large scale training data of the target city will not be involved.

Oh, I see, looks like I'm missing something. So during the meta train, the few-shot training data in target city can also be used for us because it is available. Thanks for your answer and your excellent work.

RobinLu1209 commented 2 years ago

Hello, thank you for your attention to our work! First of all, I want to stress that there is no data leakage problem here. "add_target" is an optional parameter. When it is TRUE, we will only add the few-shot training data in target city (for example, 3-day data for fine-tuning). The specific code is in dataset.py Lines 83 to 107. Therefore, the test data or large scale training data of the target city will not be involved.

Oh, I see, looks like I'm missing something. So during the meta train, the few-shot training data in target city can also be used for us because it is available. Thanks for your answer and your excellent work.

Yes, that's right! If my work is of any help to you, I would appreciate it if you could cite my paper in your work :)