search

RobinMalfait / prettier-eslint-code

[DEPRECATED] A vscode extension to format javascript using prettier-eslint
24 stars 7 forks source link

Full Prettier settings API #10

Closed GollyJer closed 7 years ago

GollyJer commented 7 years ago

Hi Robbin, Thanks for keeping this extension up to date! 🎉 Full Prettier API settings would be icing on the cake. 🎂

Prettier Settings API

RobinMalfait commented 7 years ago

Hi @GollyJer

I've thought about this, bot most of them can be set via eslint rules. But maybe I should add them just for the sake of completeness?

Let me know what you think.

GollyJer commented 7 years ago

There are times I open code and don't have .eslintrc.js and your plugin still applys formatting.

Is that correct? Something else was going on? If not then having full prettier settings eliminates the need for other prettier extensions.

The prettier-atom plugin added an "ESLint Integration" checkbox to the rest of their prettier settings. They expose all prettier and allow the user to turn on ESLint if desired.

RobinMalfait commented 7 years ago

It might be that it is the default formatting that is kicking in. If you don't have a .eslintrc file of any form. Do you see this in the bottom?

or with an X?

You can click on it to see more information, if there is an X.

GollyJer commented 7 years ago

Here's the best example I can provide. I have VSCode's javascript formatting turned off and ESLint, shown in the console output, is not loaded. 2017-04-16_10h59_24

And this single test.js file open from the desktop. 2017-04-16_11h00_01

If I format the code, Shft+Alt+F, the <View> tag moves correctly into position.
Given the settings, I can't think of what else, besides Prettier ESLint, that could be formatting the code.

RobinMalfait commented 7 years ago

Ok strange, but I added the full prettier options support in version 0.7.0