RobinMalfait / prettier-eslint-code

[DEPRECATED] A vscode extension to format javascript using prettier-eslint
24 stars 7 forks source link

try to load user's prettier-eslint first before falling back to a bundled one #21

Closed lukaszmoroz closed 7 years ago

lukaszmoroz commented 7 years ago

Also #18 It tries to find prettier-eslint relative to the edited file first.

wbern commented 7 years ago

@lukaszmoroz Do you think you could publish a fork in the mean time? I could really use a working vscode extension for prettier eslint!

wbern commented 7 years ago

@RobinMalfait Thank you Robin! Will you be publishing it today?

RobinMalfait commented 7 years ago

@wbern latest version should be published :)

wbern commented 7 years ago

@RobinMalfait I'm getting this now, both with prettier-eslint in package.json and without.

image

And sometimes as an Error instead:

image

Am I doing anything wrong? Tried removing the extension completely and installing it again.

wbern commented 7 years ago

I solved it by doing npm install inside the extension directory $HOME\.vscode\extensions\RobinMalfait.prettier-eslint-vscode-0.7.2.

Unfortunately it seems at first glance that my issue https://github.com/RobinMalfait/prettier-eslint-code/issues/27 is still relevant. :-(

RobinMalfait commented 7 years ago

@wbern what are the results when you use this package: https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode because I'm deprecating this package.

wbern commented 7 years ago

@RobinMalfait It appears to be working. Thanks for the recommendation!