search

RobinMalfait / prettier-eslint-code

[DEPRECATED] A vscode extension to format javascript using prettier-eslint
24 stars 7 forks source link

Prettier Config Options #3

Closed ltegman closed 7 years ago

ltegman commented 7 years ago

I've noticed that running prettier-eslint-code creates a different result than when I run prettier-eslint myself because my line length limits are longer than the default 80 and eslint --fix won't extend them back after prettier shortens them.

Would you accept a PR that added prettier config options to this plugin?

ltegman commented 7 years ago

Sorry, just saw that these get inferred from the eslint config so there's really no need for this. I had just typoed my line length rule so it wasn't getting picked up by eslint or the inferring logic.

RobinMalfait commented 7 years ago

Hehe it happens. I will accept PRs if needed ;)