RobinPerris / DarkUI

Dark themed control and docking library for .NET WinForms.
MIT License
834 stars 185 forks source link

Dropdown list is exhausting a lot of resource #32

Closed kreationnext closed 3 years ago

kreationnext commented 3 years ago

If a form has too many combobox, i mean dropdown list then it is using up a lot of resources as compared to other controls like textbox and others

ohhsodead commented 3 years ago

@kreationnext @RobinPerris wouldn't this have something to do with .net implementation of the combo box and not the repo owner? As the project only uses the base for the combo box and then redesigns the control to suit the dark style, rather than creating an entirely new combo box control.

RobinPerris commented 3 years ago

First, can you clarify what you mean by 'using a lot of resources'? Are you monitor CPU/RAM usage, or a dotnet mechanism like GC? Can you also clarify if this is a problem with DarkDropdownList or DarkComboBox? They are both very different controls.

DarkComboBox is really nothing more than a standard WinForms ComboBox with custom rendering overrides to change the appearance. It does use additional resources for double buffering, but a few dozen bitmaps stored in memory shouldn't cause issues.

DarkDropdownList on the other hand is a custom control written from scratch. It uses a WinForms ContextMenuStrip to render the dropdown menu itself, however, which may cause problems with significantly large collections of items.

To be honest, in the context of user experience, neither of these controls should be used for more than a dozen or so options.

kreationnext commented 3 years ago

The issue is with DarkDropdownList. I switch it to DarkComboBox, made some few edits and now its working good

RobinPerris commented 3 years ago

👍