Experiment: no dynamically loaded peers

RobinTail / express-zod-api

A Typescript library to help you get an API server up and running with I/O schema validation and custom middlewares in minutes.

https://ez.robintail.cz

MIT License

619 stars 30 forks source link

Experiment: no dynamically loaded peers #1854

Closed RobinTail closed 3 months ago

RobinTail commented 3 months ago

This can be a feature (minor release) in v20. I'm looking for the opportunity to make it simpler. Users can still upgrade sub-dependencies by running yarn upgrade or similar command of their package manager, or by reinstalling express-zod-api.

coveralls-official[bot] commented 3 months ago

coverage: 100.0%. remained the same when pulling 48f7ccb81967bb7f181ef850168614c255aa16fa on exp-no-load-peer into 1f1dab01664dc78bd6923c6bcea2ddc3d205da6b on prep-v20.

coveralls-official[bot] commented 3 months ago

coverage: 100.0%. remained the same when pulling 6e16524ed993074a8fea39f348a5388272e9a041 on exp-no-load-peer into 1f1dab01664dc78bd6923c6bcea2ddc3d205da6b on prep-v20.

RobinTail commented 3 months ago

Not sure about this 6e16524

Pro:

it's easier to use

Cons:

breaking change to beforeRouting (reduced feature)
locking the further development of such feature as "wait before it actually starts listening"

coveralls-official[bot] commented 3 months ago

coverage: 100.0%. remained the same when pulling 9518234d706aef46e3a64cb9eb0ab2da398834aa on exp-no-load-peer into 1f1dab01664dc78bd6923c6bcea2ddc3d205da6b on prep-v20.

coveralls-official[bot] commented 3 months ago

coverage: 100.0%. remained the same when pulling 9518234d706aef46e3a64cb9eb0ab2da398834aa on exp-no-load-peer into 1f1dab01664dc78bd6923c6bcea2ddc3d205da6b on prep-v20.

coveralls-official[bot] commented 3 months ago

coverage: 100.0%. remained the same when pulling 7c802b053fb70562fe50d6b40a94586638b84de9 on exp-no-load-peer into 1f1dab01664dc78bd6923c6bcea2ddc3d205da6b on prep-v20.

RobinTail commented 3 months ago

I actually wanted the uploads to be an opt-in feature. Not everyone needs it. Also, Such things as prettier can also be involved by consumer, and I didn't want multiple versions to be installed.