search

RobinUS2 / presto-bloomfilter

Bloomfilter support for Facebook Presto (prestodb.io)
Apache License 2.0
25 stars 10 forks source link

Function to aggregate bloomfilters #22

Open juanpampliega opened 7 years ago

juanpampliega commented 7 years ago

Hi, From my initial assessment there currently is no function to aggregate a column of BloomFilters to generate a new BloomFilter from this aggregation. Looking at the code a function could be easily implemented that uses internally the putAll() function. Is there any reason in particular you haven't done this? I could try adding this feature and sending a PR.

RobinUS2 commented 7 years ago

Thanks for reaching out @juanpampliega . There's no specific reason for not implementing this, simply a lack of need so far. Feel free to go ahead and implement this one, preferably with a (couple of) test(s) as I could definitely see how this would be helpful.