search

Robinfr / electron-react-typescript

Electron boilerplate with React, Redux, and TypeScript
MIT License
432 stars 85 forks source link

Multiple hot-loader recompilation events #6

Closed rhyek closed 5 years ago

rhyek commented 6 years ago

On a newly cloned copy, with npm 6.3.0 running npm i && npm run start-dev I get the following behavior:

image

After a bit the events stop and hot reloading works as normal.

After npm i there are several modifications done to package-lock.json:

rhyek commented 6 years ago

Btw, if it doesn't do it the first time, close the app and restart it. I should also mention that this is on Ubuntu 18.04.

rhyek commented 6 years ago

It is not an issue with the updated packages. I have tried npm ci and I get the same behavior.

bnsv-jason commented 6 years ago

Not sure what about awesome-typescript-loader caused the issue but switching to ts-loader won't cause the same issue.

Kaffiend commented 6 years ago

i'm seeing the same behavior on win10. ill try ts-loader.

Robinfr commented 6 years ago

I'm pretty sure this is an issue with awesome-typescript-loader. Maybe related to https://github.com/s-panferov/awesome-typescript-loader/issues/502 ?

Does it keep happening for every change? If the ts-loader works better I'll consider switching the project over to that.

Robinfr commented 5 years ago

Should be fixed now!