search

Robinlovelace / simodels

https://robinlovelace.github.io/simodels
GNU Affero General Public License v3.0
15 stars 4 forks source link

Add intrazonal = TRUE argument to si_to_od() #18

Closed R-icntay closed 2 years ago

R-icntay commented 2 years ago

Hello Robin,

Here goes the first version of my contribution to #16 .

The current modification is a check for whether Euclidean distance > 0. Perhaps in the future we may want to compare origin codes and destination codes? Say for instance, the origin and destination coordinates of a trip are different but in the same zone, this would still qualify as an intrazonal trip.

Please feel free to share your thoughts on the changes.

Thank you.

Eric.

Robinlovelace commented 2 years ago

OK going to merge and do post merge fixes as that will be quicker, more changes incoming, many thank Eric!

R-icntay commented 2 years ago

first PR to an R package repo

Hello Robin,

Yes this is my first PR to an R package 🤗. Please feel free to offer correction in case the PR was not done the right way :)

Thanks a lot for looping me in. Happy to contribute again.

Robinlovelace commented 2 years ago

Yes this is my first PR to an R package hugs. Please feel free to offer correction in case the PR was not done the right way :)

:tada:

Please add yourself as a contributor here if you want to get credit when it (hopefully fairly soon) goes on CRAN: https://github.com/Robinlovelace/si/blob/main/DESCRIPTION