Update to 2023.2.0f1 API/URP 16.0

[adrian-miasik]

Overview

Updates the project to support Unity v2023.2 + Universal Render Pipeline v16.04

Purposely tried to make as few changes as possible to get this to work. Credit goes to @Chishikii for figuring out how to get this up and running in Unity 2023.2. I don't fully understand the use cases for the occluder, so would appreciate another set of eyes there on how it was implemented but generally I've tried to make no real changes to the logic except what was needed to get this working.

Though I recommend we use @Chishikii's solution instead: https://github.com/Chishikii/URP-Render-Features/blob/main/Assets/Render%20Features/Outlines/OutlineRenderFeature.cs

It has a ton of comments and I would argue it's a better approach. Though if you want less changes, use this.

Summary

• Update logic to use URP 16.0 API
  • Use RTHandles instead of RenderTargetIdentifier
  • Use Blitter.BlitCameraTexture (2022.2+) instead of obsolete ScriptableRenderPass.Blit
  • Fixes #15
• Convert Outlines.shadergraph use fullscreen material + Implement URP sample buffer node
• Merged the two render passes into a single pass
• Merged the two settings objects into one
• Properly dispose of render textures. Original logic disposes in OnCameraCleanup which seems to break the Unity Toolbar UI. Instead we dispose when the RendererFeature does.
  • Hopefully fixes #26
• Seems to support stacking of RenderFeature (Can have multiple outlines at once)

Sources/References

• https://github.com/Chishikii/URP-Render-Features
• https://www.cyanilux.com/tutorials/custom-renderer-features/
• https://docs.unity3d.com/Packages/com.unity.render-pipelines.universal@16.0/manual/renderer-features/how-to-fullscreen-blit.html

[adrian-miasik]

We can probably use CoreUtils.Destroy() instead to dispose of the materials.

[Robinseibold]

Great work @adrian-miasik! Will hopefully get time to review close and possibly merge it later this week.

[adrian-miasik]

Glad I could be of some service!

I'll probably push a couple more commits to this before review, with things such as using CoreUtils and checking RT's before usage (currently gets a null error).

Another thing of note, is that it seems like the new RTHandle system can't handle color and depth data at the same time? https://forum.unity.com/threads/can-i-get-a-rt-with-a-depthstencil-buffer-using-rthandles-if-not-why.1404010/

[Chishikii]

Another thing of note, is that it seems like the new RTHandle system can't handle color and depth data at the same time? https://forum.unity.com/threads/can-i-get-a-rt-with-a-depthstencil-buffer-using-rthandles-if-not-why.1404010/

You're absolutely right they can't which is a shame but oh well. We can however just reuse the cameras depth buffer. We just need to clear it before with cmd.ClearRenderTarget(). I've fixed all the issues I found in my repo.

Currently there is no option for occlusion objects. I'll try to add that as well once i have the time. Should be fairly simple now that everything else works.

[Robinseibold]

I'll probably push a couple more commits to this before review, with things such as using CoreUtils and checking RT's before usage (currently gets a null error).

Beautiful! Will track this.

[roomyrooms]

Heya, I appreciate the work you guys are doing as I'm currently using a lower Unity + URP version solely because of this package, which is the only one I've found to work in my circumstances. It's a bit out of my depth to fix anything in it ATM, so your work is great!

If it's not too complicated / time-consuming, do you think it'd be possible to include alpha testing in this fix as well? No worries if not. Thanks for your contribution :)

[adrian-miasik]

Alright, I've pushed the last couple commits I've had. Should be good to look over! 🤞

As for alpha testing, that should probably be a separate issue/PR unless it's a breaking feature change. (Maybe I'm misunderstanding?) @roomyrooms, can you elaborate a bit further on what you mean by alpha testing? I don't think this project supported transparent/alpha materials before (see #19), but perhaps you mean something different?

[Robinseibold]

Great work @adrian-miasik !

It took me some time to get it to work because of two reasons:

• It seems to only work if ScreenSpaceOutlineSettings.depthBufferBits = 0
• ScreenSpaceOutlines.renderPassEvent < RenderPassEvent.BeforeRenderingSkybox results in a form of Outlines "shadow" artefact.

Anything occluder related is no longer needed because of proper depth setup in ConfigureTarget:

ConfigureTarget(normals, renderingData.cameraData.renderer.cameraDepthTargetHandle);
ConfigureClear(ClearFlag.Color, settings.backgroundColor);

So if you could just make the following changes:

• Set ScreenSpaceOutlineSettings.depthBufferBits default value to 0
• Set ScreenSpaceOutlines.renderPassEvent default value to RenderPassEvent.BeforeRenderingSkybox
• Remove any code related to occluder both in ScreenSpaceOutlinePass and ScreenSpaceOutlines
• Remove the UnlitColor shader

I'd be more than happy to merge this into main.

[adrian-miasik]

• It seems to only work if ScreenSpaceOutlineSettings.depthBufferBits = 0

I should have specified this, since this is the only way I could also get it to work. Whoops. 😅

ScreenSpaceOutlines.renderPassEvent < RenderPassEvent.BeforeRenderingSkybox results in a form of Outlines "shadow" artefact.

Do you have a visual reference/screenshot of what this looks like? Will still change the default to RenderPassEvent.BeforeRenderingSkybox like you suggested.

Remove any code related to occluder both in ScreenSpaceOutlinePass and ScreenSpaceOutlines

Understood!

Remove the UnlitColor shader

I don't think I've....Ohhh, yeah the occluder set shader.

---

Okay I'll get on this. Thanks for the detailed breakdown. I'll likely tackle this before the end of the week. Will report back and ping you once it's ready!

[adrian-miasik]

Okay @Robinseibold, I've made the necessary changes. Working as intended. Ready for re-review/merge! 🤞