search

Robit / SocialDistancing

A quarantine-enforcing April Fools plugin for the Spigot API
MIT License
2 stars 0 forks source link

Pushing NPCs #1

Open Sam1370 opened 3 years ago

Sam1370 commented 3 years ago

One spigot user left this comment: "The plugin is fine but its only problem is that it also pushes NPCs. If that problem were fixed, I would post it in my network lobby during this pandemic." You responded, perplexed: "It should only push entities that are instances of Players, so I'm curious how it could be pushing NPCs. Could you possibly create an issue on the github and also specify the nature of these NPCs? Specifically if they're instances of fake players."

I believe what the spigot user is talking about is an NPC from CitizensNPC. https://www.spigotmc.org/resources/citizens.13811/

It should be possible to hook into the citizens api (if it exists) and check if a player is an NPC.

Robit commented 3 years ago

I don't intend to develop this plugin anymore. Anyone's free to fork it under the terms of the MIT license

Sam1370 commented 3 years ago

I think it would be best to still leave the issue open; even if you do not intend to fix it, it is still an issue. Marking it closed makes the issue seem as if it is resolved.