search

Roblox / Core-Scripts

All of ROBLOX's core client scripts.
Apache License 2.0
252 stars 184 forks source link

Inviscam in first person doesn't ignore the character #1015

Closed Quenty closed 4 years ago

Quenty commented 7 years ago

When in first person the invisicam system doesn't ignore the character. This is due to a call to 

local partsTouchingCamera = game.Workspace:FindPartsInRegion3(region3,nil,10)

which should be 

local partsTouchingCamera = game.Workspace:FindPartsInRegion3(region3,Character,10)

Character is not ignored in first person with invisicam enabled causing an issue where in first person you can see your character's body as invisicam glitches out with the the TransparencyController not updating every frame.

This only happens when running or when the character is moved a bit from the camera origin.

As in first person it finds parts parented to the Character.

I have a pull request here to fix that.

See pull request: https://github.com/Roblox/Core-Scripts/pull/1014

Reproduction

  1. Create a new place
  2. Set camera mode to inviscam
  3. Zoom in all the way
  4. Look straight down
  5. Walk around a bit

image

Expected behavior: Arms, nothing else shows up. This is even worse with some animations I'm running on my character which makes invisicam unplayable.

https://github.com/Roblox/Core-Scripts/pull/1014

Quenty commented 7 years ago

See https://devforum.roblox.com/t/inviscam-doesnt-ignore-character-in-first-person/48365

cliffchapmanrbx commented 4 years ago

Hi there, thank you for your feedback. We're going to be closing this repository as we've chosed the Roblox Dev Forum as our venue for developer feedback. Please feel free to migrate your feedback to a DevForum post if you feel it is still relevant.