search

Roblox / Core-Scripts

All of ROBLOX's core client scripts.
Apache License 2.0
247 stars 182 forks source link

Dialog object does not reset after activation #546

Closed LucasWolschick closed 7 years ago

LucasWolschick commented 7 years ago

After using a Dialog, you can never use it again (prompt bubble never shows up after dialog conclusion).

Steps to reproduce:

  1. Create/visit any place which has a dialog
  2. Use the dialog, end it in any point ("Goodbye!", or reaching the end)
  3. Notice how the prompt bubble never shows up again.
athraxkobal commented 7 years ago

Prompt bubble will appear after a long while.

However, this is still an issue that I want fixed.

LucasWolschick commented 7 years ago

No, really, the prompt bubble won't show up again

LucasWolschick commented 7 years ago

Any thoughts on this?

Quenty commented 7 years ago

This occurs only when FilteringEnable is turned on, and is due to a big where the property doesn't replicate back to the server. The legacy code spawned in a script, but in the case of FilteringEnabled, this is not viable.

LucasWolschick commented 7 years ago

@Quenty, I've already tested it in several non-filteringenabled games as well as filteringenabled ones, and I can say the same bug happens in all cases.

athraxkobal commented 7 years ago

Tested with Test Server in studio, for me the bug occurs in both FE and non-FE. I'm going to be looking around for cases where the prompt does pop up again, it's hard though.

On Thu, Sep 29, 2016 at 6:14 PM, LucasWolschick notifications@github.com wrote:

@Quenty https://github.com/Quenty, I've already tested it in several non-filteringenabled games as well as filteringenabled ones, and I can say the same bug happens in all cases.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ROBLOX/Core-Scripts/issues/546#issuecomment-250606717, or mute the thread https://github.com/notifications/unsubscribe-auth/APcwpcybQFg1E7lAWH1q-iqpWKdMhfmKks5qvDgsgaJpZM4J9-Zp .

LucasWolschick commented 7 years ago

I don't seem to find any scenario in which the prompt appears again.

ghost commented 7 years ago

I can't replicate this, the prompt bubble reappears for me.

DarraghGriffin commented 7 years ago

I think this is fixed by #566

ghost commented 7 years ago

This issue was moved to GitBlox/Core-Scripts#26

LucasWolschick commented 7 years ago

I can't replicate this anymore too, guessing it was fixed.