Roblox / cla-signature-bot

GitHub Action for self-contained handling of CLA signatures
Apache License 2.0
17 stars 13 forks source link

feat: add shared workflow #35

Closed rgychiu closed 1 year ago

rgychiu commented 1 year ago

This adds a called workflow to allow other GHC repositories to use this instead of having to rewrite the CLA bot workflow from scratch. In addition, this allows for updating the workflow without needing to update the downstream repositories.

Notes

github-actions[bot] commented 1 year ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

rgychiu commented 1 year ago

Note to self to change the workflow reference to @main instead of a specific hash before merging. This was changed to be able to run the workflow to test without needing it to be merged.

rgychiu commented 1 year ago

Can we instead just have clabot.yml have the same check name though? Why do we need to update the downstream repositories?

Did some digging and it seems like the check name changes since we're using a reusable workflow. Also couldn't find anything to see if I could keep the check name the same, but I could be missing something.

We have to update the downstream repositories since they all have their own local copy of the cla bot workflow. They need to be updated to v2.0.2 since I released that version, but we can change their workflows to leverage this shared workflow instead. This lets us update the bot version in this repository and not have to touch the other repos after the batch change.