Roblox / foreman

Toolchain manager for Roblox projects
MIT License
178 stars 26 forks source link

Make Foreman exit with code from underlying tool #20

Closed LPGhatguy closed 4 years ago

LPGhatguy commented 4 years ago

Foreman was not correctly propagating error codes when it ran an underlying tool. This wasted a bit of time elsewhere, and we didn't think to blame Foreman! 😅

I updated the signature of ToolCache::run to hopefully prevent this exact issue from popping up in the future. Had we annotated this function before, this bug would not have happened.