search

Roblox / foreman

Toolchain manager for Roblox projects
MIT License
171 stars 26 forks source link

Use group status to report exit code #41

Closed oltrep closed 2 years ago

oltrep commented 2 years ago

A quick fix to correctly report exit code for long process runs.

github-actions[bot] commented 2 years ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

oltrep commented 2 years ago

Not really, because I would need to install a real tool and call it to see if it returns the correct exit code. That would not test exactly the fix here, but more the behavior in general.

ZoteTheMighty commented 2 years ago

Not really, because I would need to install a real tool and call it to see if it returns the correct exit code. That would not test exactly the fix here, but more the behavior in general.

Would it be possible to do this via a shell script that exits with an error or something else super simple, or would that be clumsy to set up?