Roblox / foreman

Toolchain manager for Roblox projects
MIT License
178 stars 26 forks source link

APT-703 Properly Kill Subprocesses With ctrl-c #81

Closed afujiwara-roblox closed 1 year ago

afujiwara-roblox commented 1 year ago

Running commands like "rojo serve" and pressing ctrl-c does not kill the rojo process as intended. Foreman should pass the signal to the tools it runs. This PR implements the same solution from Aftman

Manually tested ctrl-c kills subprocesses on M2 mac and Windows machines Added 2 scripts to CI to test subprocess are properly killed on linux and windows machines