search

Roblox / future-is-bright

Prototyping future Roblox lighting technology
https://roblox.github.io/future-is-bright/
60 stars 12 forks source link

Poor Rendering with New Engine #40

Closed popomcnuggets closed 5 years ago

popomcnuggets commented 7 years ago

Although I do believe the new rendering can be quite delightful, there are some issues concerning switching over to the new engine. I have attached before and after images of my personal fan builds, with adjusted lighting in the new and old lighting engines. The issues appear to be quite distinct.

Before:

After (Cascaded):

After (VoxelCPU):

After (ShadowMap):

Before:

After (Cascaded):

After (VoxelCPU):

After (ShadowMap):

popomcnuggets commented 7 years ago

A possible solution that I'd be perfectly okay with is to leave the current lighting engine as an option, even if it does not get tuned.

hoontee commented 7 years ago

HDR is the issue. It's independent of the new lighting modes, so when we get the option to disable HDR your issue will be fixed.

plasma-node commented 7 years ago

What @hunte922 Is true, try messing with the exposure and it should do some good

skedgywasedgy commented 6 years ago

Well the lighting is weird on the second because of the new lens flare effects for Neon.

zeux commented 5 years ago

Closing this since it's an old issue and we've changed the HDR impl / neon quite a bit since then. It won't match the old results perfectly but there should be a reasonable amount of control to tweak it.