search

Roblox / roact

A view management library for Roblox Lua similar to React
https://roblox.github.io/roact
Apache License 2.0
558 stars 143 forks source link

Add Wally manifest file #314

Closed LPGhatguy closed 2 years ago

LPGhatguy commented 2 years ago

This PR adds a Wally manifest file to the repository for the latest release of Roact.

Wally is a package manager for Roblox developed at Uplift Games. It's part of our initiative to create an open ecosystem of shared, accessible code and high quality tooling for Roblox developers.

We launched Wally today with a small set of packages available to start; Roact is one of them. With Wally, adding Roact to an existing Roblox project that uses Rojo is very easy:

[package]
name = "lucien/lets-use-roact"
version = "0.1.0"
registry = "https://github.com/UpliftGames/wally-index"
realm = "shared"

[dependencies]
Roact = "Roblox/roact@1.4.0"
$ wally install
[INFO ] Updating package index...
[INFO ] Downloading roblox/roact@1.4.0...

Though merging this PR isn't required for Roact to be available to Wally users, we would love it for Roblox-owned open source packages to be published by Roblox on our package registry. Having a manifest file is an easy step in that direction.

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 94.783% when pulling 020130acd7f39f98301c69b2ca9216e46677b1d6 on LPGhatguy:master into 2239e01f1664b2f82a21e73a166cc0fc807de033 on Roblox:master.

jhampton commented 2 years ago

This is currently being reviewed and discussed with teams here. Thank you for the contribution, and we will respond shortly. ETA for decision is 8/13/2021. (cc @ZoteTheMighty )

LPGhatguy commented 2 years ago

Hello, it's been a little while. Any update on conversations about this?

u-train commented 2 years ago

Ping again! Are there any updates on this PR? Also, includes and excludes now exist, so it would be nice to add them for this PR!