Enforce code style and linting to eliminate Studio indentation warnings

Roblox / roact

A view management library for Roblox Lua similar to React

https://roblox.github.io/roact

Apache License 2.0

557 stars 143 forks source link

Enforce code style and linting to eliminate Studio indentation warnings #321

Closed matthargett closed 2 years ago

matthargett commented 2 years ago

Supercedes PR #313 .

Rather than spot fix one styling issue, let's mistake-proof it.

Checklist before submitting: CI-only and non-functional, so no CHANGELOG or test updates needed

* [ ] Added entry to `CHANGELOG.md`
* [ ] Added/updated relevant tests

[x] Added/updated documentation

matthargett commented 2 years ago

Can you doublecheck this in Studio and make sure this eliminates the warning, and doesn't introduce any others? StyLua and Selene may not share the same expectations as the script analyzer

Verified, and went a little further to pin a few files as strict/nonstrict.

ZoteTheMighty commented 2 years ago

Took a closer look and it seems like you made changes to the testez submodule, any reason?

matthargett commented 2 years ago

Took a closer look and it seems like you made changes to the testez submodule, any reason?

Not sure how that happened. Let me try reverting that.

coveralls commented 2 years ago

Coverage increased (+0.02%) to 94.802% when pulling bf2246c6dccef2774a9da08a7e2cd1ed45d5ac28 on stylua into 103bd1831605c1ec32ee7f85bc703346ad6c1c45 on master.