#nojira gracefully handle double unmount.

Roblox / roact

A view management library for Roblox Lua similar to React

https://roblox.github.io/roact

Apache License 2.0

557 stars 143 forks source link

#nojira gracefully handle double unmount. #327

Closed dougbankspersonal closed 2 years ago

dougbankspersonal commented 2 years ago

I was running code in lua-app that exposed a bug in roact so that things were getting unmounted twice, which would lead to a crash. Change so it gracefully handles being unmounted twice.

coveralls commented 2 years ago

Coverage increased (+0.004%) to 94.787% when pulling 524cfae389aaccbc2f80851008405fbbd3dc86b1 on dougbankspersonal:nojira/gracefilly_handle_double_unmount into c2d515d926d8f0df02afcf9af64625860ed7f93d on Roblox:master.

github-actions[bot] commented 2 years ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

dougbankspersonal commented 2 years ago

I have read the CLA Document and I hereby sign the CLA