search

Roblox / rodux

A state management library for Roblox Lua inspired by Redux
https://roblox.github.io/rodux
Apache License 2.0
250 stars 57 forks source link

Update version and make new release or tag #73

Closed Corecii closed 2 years ago

Corecii commented 2 years ago

Uplift has been publishing versions of Rodux and Roact to the Wally index for Roblox. Some users want updated versions of Rodux, but we're stuck because the Rodux version has not changed and we don't want to publish a conflicting version now.

Here are some options I discussed with some people:

  1. We publish version 3.0.1, which will conflict when Roblox officially releases that version (bad! I don't really consider this an option.)
  2. We publish 3.0.1-ce63e3d (or similar) which won't conflict with any version Roblox releases, but will require explicitly specifying in wally.toml since it's a prerelease tag version
  3. You all update the Rodux version officially, then we publish with Wally.

Here's # 3! This would be the cleanest solution to give users an up-to-date version of Rodux. A new Release, Tag, or updating rotriever.toml with a new version is all we need to be confident that we can safely publish that version.

Corecii commented 2 years ago

I realize now that these changes are intentionally "unreleased" according to the changelog. From an external viewpoint, it's hard to keep track of how releases work with these open source modules since I've seen it suggested around that how releases are done isn't always consistent!

Sorry for the extra prodding then -- I'm just forwarding comments from Wally users and looking for solutions. I think now the best solution is either to wait for a release from you all or publish a prerelease version. (On that note, I wouldn't mind an official version with these changes. It would make this decision easier, even if it's an official prerelease version like 3.1.0-beta1 or something.)

ghostnaps commented 2 years ago

We'll be publishing a v4 release candidate to address this. Since the Luau types we've introduced break analysis, we're opting for a new major version. We'll also look to getting this release published to the Wally registry for community consumption as well

Corecii commented 2 years ago

Great, thank you!

We'll also look to getting this release published to the Wally registry for community consumption as well

Uplift Games has been publishing these packages to Wally for you all. Would you like us to publish 4.0.0-rc.0 for you, or do you want to take on responsibility of publishing versions to Wally yourself? I can give you access to publish under roblox on the Wally registry if you want to start publishing it yourself!