Only call Signal tracebacks in dev mode

Roblox / rodux

A state management library for Roblox Lua inspired by Redux

https://roblox.github.io/rodux

Apache License 2.0

254 stars 56 forks source link

Only call Signal tracebacks in dev mode #78

Closed jkelaty-rbx closed 2 years ago

jkelaty-rbx commented 2 years ago

Moves Signal connect() and disconnect() tracebacks under a dev flag. The remaining debug.traceback() calls will all immediately throw an error, so there's no point in calling them conditionally.

coveralls commented 2 years ago

Coverage decreased (-0.7%) to 98.507% when pulling 47e39c1f908a6120a5226f3c0a524a7ec49f2887 on jkelaty-rbx:dev-mode-connect-traceback into a5002a39d94b17494d3481a9aae1583490b96aee on Roblox:master.

github-actions[bot] commented 2 years ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.