search

Roblox / rs-consul

This crate provides access to a set of strongly typed apis to interact with consul (https://www.consul.io/)
MIT License
35 stars 23 forks source link

read json from response buffer instead of copying #25

Closed polachok closed 1 month ago

polachok commented 2 years ago

What problem are we solving?

mut and copy

How are we solving the problem?

removing mut and copy

Checks

Please check these off before promoting the pull request to non-draft status.

ChrisluRoblox commented 2 years ago

Thanks for this PR. Is it possible to add some tests for this?

github-actions[bot] commented 2 years ago

CLA Signature Action:

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to our company's repositories.

0 out of 1 committers have signed the CLA. :x: @polachok

kushudai commented 1 year ago

Hi @polachok thank you for this! Would you be willing to sign the CLA so we can accept this change?