search

Roblox / rs-consul

This crate provides access to a set of strongly typed apis to interact with consul (https://www.consul.io/)
MIT License
36 stars 23 forks source link

Add datacenter field to Node type #27

Closed tdinh2212 closed 2 years ago

tdinh2212 commented 2 years ago

What problem are we solving?

We need datacenter to be able to construct a DNS hostname for a consul service. Specifically, it has the form: {service_name}.service.{datacenter}.consul.

How are we solving the problem?

  1. Add datacenter attribute to Node type.
  2. Make get_cluster_service_nodes test meaningful by configuring 3 dummy endpoints without any healthchecks.

Checks

Please check these off before promoting the pull request to non-draft status.

github-actions[bot] commented 2 years ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

tdinh2212 commented 2 years ago

I have read the CLA Document and I hereby sign the CLA