Roblox / rs-consul

This crate provides access to a set of strongly typed apis to interact with consul (https://www.consul.io/)

MIT License

35 stars 23 forks source link

Closed arthurprs closed 1 year ago

arthurprs commented 1 year ago

What problem are we solving?

openteletry support is using a very old version
openteletry might be unnecessary to most users, and there's precedent (prometheus metrics) for making such things optional with features.

Update opentelemetry to 0.18 and make it optional via a feature

Please check these off before promoting the pull request to non-draft status.

kushudai commented 1 year ago

Hi @arthurprs, Thank you for this change. Could you sign the CLA so I can accept it?

github-actions[bot] commented 1 year ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

arthurprs commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

kushudai commented 1 year ago

Thank you! I will merge this and release a new version with all the breaking changes this week.