Roblox / rs-consul

This crate provides access to a set of strongly typed apis to interact with consul (https://www.consul.io/)

MIT License

35 stars 23 forks source link

Add `ConsulBuilder` allowing a consul client to be built using a custom HTTP connector, fixes #44 #45

Closed LeonHartley closed 1 month ago

LeonHartley commented 4 months ago

What problem are we solving?

Issue #44

How are we solving the problem?

Create a new consul client builder allowing a custom HTTP client to be supplied, whilst keeping current API as-is so as to not introduce any breaking changes.

Checks

Please check these off before promoting the pull request to non-draft status.

[ ] All CI checks are green.
[ ] I have reviewed the proposed changes myself.

github-actions[bot] commented 4 months ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

LeonHartley commented 4 months ago

I have read the CLA Document and I hereby sign the CLA

kushudai commented 4 months ago

Hi @LeonHartley Thank you for the issue and the PR!

This mostly looks good to me. I have 2 relatively small (I hope) asks:

Could we take the hyperBuilder currently in the config and also move it to ConsulBuilder?
Could you also run cargo fmt to fix the lint?