Closed gautamg795 closed 2 months ago
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
I have read the CLA Document and I hereby sign the CLA
thanks for the quick review! I've fixed the failing tests; didn't realize the Consul config needed to be updated in the test config as well
thanks for the quick review! I've fixed the failing tests; didn't realize the Consul config needed to be updated in the test config as well
Thank you for the change! Adding a field to a public type is a breaking change so I will need to make a minor version change for a release. I should be able to get that out by next week.
What problem are we solving?
get_service_nodes
currently does not include a service's tags in the returned struct.How are we solving the problem?
Just deserialize the tags into a
Vec<String>
; the data is already present in the response.Checks
Please check these off before promoting the pull request to non-draft status.