search

Robo3D / roboOctoprint

Octoprint tailored for Robo printers.
GNU Affero General Public License v3.0
3 stars 4 forks source link

[BUG] Access control will mess up plugins after it is enabled #22

Open Ximidar opened 6 years ago

Ximidar commented 6 years ago

@peries enabled access control and then started a print with no filament. The filament sensor failed to start. Rebooting fixed the problems with the Filament Sensor. Access control may be messing with other plugins as well. Instead of just reloading, we should reboot the system after access control is enabled to avoid any unintentional errors.

peries commented 6 years ago

@Ximidar the problem happened when I disabled access control and tried to run the first print. When it was enabled it was working fine

Ximidar commented 6 years ago

@peries @mnacinopa I updated the Filament sensor on your machines, If you could test it that would be great

Ximidar commented 6 years ago

This bug has more to do with how we shut down the Octoprint instance. Some plugins have threads and processes that spawned, but are not controlled when it's time to shut down. The threads will eventually shut down, but the processes will hold on to the octoprint instance.