search

RoboCup-SPL / GameController3

This is the official GameController used in the RoboCup Standard Platform League
MIT License
16 stars 8 forks source link

package-lock.json should be committed to git #38

Closed jayenashar closed 1 year ago

jayenashar commented 1 year ago

this ensures that npm installs the same version of packages for everyone. people should use npm ci when creating a production build instead of npm install.

(i use yarn not npm or i'd submit a PR)

ahasselbring commented 1 year ago

Yeah, this is part of what I meant by #13.

jayenashar commented 1 year ago

oh i saw that issue but only saw cargo mentioned so i skipped it. i missed the package.json mentions.

normally for node, you have both package.json and package-lock.json in git.