RoboCup-SPL / GameController3

This is the official GameController used in the RoboCup Standard Platform League
MIT License
16 stars 8 forks source link

the Ready Delay will be skipped by robot communication #54

Closed pupubushilulu closed 4 months ago

pupubushilulu commented 6 months ago

If a robot attempts to send messages to teammates during the initial state (which can also be considered as an attempt to communicate with the Game Controller), the delay in the Ready phase will be nullified (ending prematurely). Here is an example: someone clicked the the "Ready" button and one robot sent a message to other robots during the ready delay, then the ready signal will be sent to all robots immediately (which should be sent after the ready delay).

ahasselbring commented 6 months ago

Thank you for this interesting report! It is a consequence of the rule that team messages are not counted during the Initial state, and therefore it is pointless for the GameController to pretend that it is not Ready when the message counter decreases. I have forwarded this to the TC since my preferred solution requires a rule change: https://github.com/RoboCup-SPL/Rules/issues/151

pupubushilulu commented 6 months ago

Ok, thanks for your response.

ahasselbring commented 4 months ago

322f522 fixed the issue.