RoboCup-SSL / grSim

RoboCup Small Size Robot Soccer Simulator
https://ssl.robocup.org/league-software/
Other
128 stars 133 forks source link

Fix compatibility for both divisions #66

Closed jgkamat closed 6 years ago

jgkamat commented 6 years ago

This is a follow-up to https://github.com/RoboCup-SSL/grSim/pull/59.

We are trying to update our software to work with the new field sizes and goal area format (which correspond with grSim, since ssl-vision still hasn't updated), and I noticed that the last checkbox of https://github.com/RoboCup-SSL/grSim/pull/59 was not completed. Is there an easy way to switch between divisions right now, I couldn't find any.

Right, now, the field seems to be incorrect for both divisions going off of this diagram for quad and this diagram for double. The goal zone seems to match the quad size goal zone (2.4 by 1.2), but the actual field size seems to match the double field size (6 by 9).

If possible, could we have a switch to easily switch between the leagues? I would be happy to help with updating the config and adding the switch if you would like, but I wanted to get some feedback/guidance first.

mahi97 commented 6 years ago

Right, now, the field seems to be incorrect for both divisions going off of this diagram for quad and this diagram for double. The goal zone seems to match the quad size goal zone (2.4 by 1.2), but the actual field size seems to match the double field size (6 by 9).

The field configs are in vartypes so you can change them and see the result at the same time. I wanted to make the default values of parameters for division A but as you said it should be fixed for field-size.

If possible, could we have a switch to easily switch between the leagues? I would be happy to help with updating the config and adding the switch if you would like, but I wanted to get some feedback/guidance first.

I think the easiest way is to add another field config and have both field parameters in the same file, then we can switch the parameters by a hotkey or button in GUI or by a checkbox in vartypes.