search

RoboCup-SSL / grSim

RoboCup Small Size Robot Soccer Simulator
https://ssl.robocup.org/league-software/
Other
127 stars 130 forks source link

Field Line coordinate autogeneration is inconsistent with SSL-Vision's generated coordinates #89

Open rolfvdhulst opened 5 years ago

rolfvdhulst commented 5 years ago

In SSLWorld.cpp the geometry is generated. The centre of each line is corrected by amount of LineThickness, however, in SSL-vision this does not happen. Not sure which one to take, but atleast both GrSim and SSL-vision should be consistent with each other.

mahi97 commented 5 years ago

IMHO, You should try to be robust and more flexible to this configuration at this rate, we experienced robocups with wrong field size!

But you're right, we can at least have an standard about line and area of the field (maybe it's mentioned in rules implicitly).

Anyway, please feel free to send a pull request if ssl technical committee agreed on any of them.

rolfvdhulst commented 5 years ago

The problem was the rules did not mention a standard implicitly on how the lines should be communicated through vision (e.g. take the 'outside' or the centre of the line), and this makes it easy to misinterpret. I notified the technical committee but still wanted to make this an issue so that users are aware.

g3force commented 3 years ago

There is an issue for this issue: https://github.com/RoboCup-SSL/ssl-rules/issues/33

I've just created a patch for clarification in the rules. That would mean, we would adapt the behavior in grSim two that of ssl-vision.