search

RoboCup-SSL / ssl-logtools

GNU General Public License v3.0
10 stars 9 forks source link

Qt 5 support + warning fixes #8

Closed MichaelEischer closed 6 years ago

MichaelEischer commented 6 years ago

The pull request adds support for building with Qt5. Modify the cmake command to cmake -DUSE_QT5=True .. to build with Qt5. These changes are accompanied by several fixes for compiler, protobuf and qt warnings.

It might be worthwhile to raise the required version to CMake 3.5 and Qt 5.2. Even those library versions are old enough to be available on Ubuntu 14.04 (CMake is available as a backported package named cmake3). This would allow for several cleanups such as dropping qt4 support, "modern" cmake based on targets. As Qt5 also includes a commandline-options parser the dependency to boost could be removed.

g3force commented 6 years ago

I have added travis support now and added USE_QT5 to the build matrix. Could you update your branch to see if both settings build on trusty?

MichaelEischer commented 6 years ago

So, now the branch is building with both Qt4 and 5 in Travis

g3force commented 6 years ago

LGTM

I'd say, as long as the tools can be built on Ubuntu 14.04 with default apt repositories, QT and cmake could be updated as you said and be made default.

MichaelEischer commented 6 years ago

I think that fully migrating to qt5 should be a separate follow-up merge request. I'm currently not sure when I will have time to finish the migration.