RoboCup-SSL / ssl-vision

Shared Vision System For The RoboCup Small Size League
GNU General Public License v3.0
88 stars 109 forks source link

plugin_neuralcolorcalib: don't accept every mouseReleaseEvent #102

Closed g3force closed 6 years ago

g3force commented 6 years ago

Previously, ssl-vision crashed when dragging a control point used for camera geometry calibrtion and afterwards dragging without hitting a calibration point.

This happend due to plugin_cameracalib relieing on the fact that there is always a mouseReleaseEvent for every mousePressEvent. This did not hold true as plugin_neuralcolorcalib always accepted mouseReleaseEvents and is prior in the plugin queue. This results in dereferencing an nullptr in plugin_cameracalib.cpp in ln. 343 as soon as a drag event fires after an unsuccessful mousePressEvent (because of not hitting the control point).

Signed-off-by: Andreas Wendler andreas.wendler@robotics-erlangen.de Signed-off-by: Tobias Heineken tobias.heineken@robotics-erlangen.de Signed-off-by: Paul Bergmann paul.bergmann@robotics-erlangen.de