search

RoboCup-SSL / ssl-vision

Shared Vision System For The RoboCup Small Size League
GNU General Public License v3.0
90 stars 111 forks source link

[#87] Add type enum to geometry proto for lines and arcs #130

Closed g3force closed 5 years ago

g3force commented 5 years ago

closes #87

g3force commented 5 years ago

I started this one last year. Time to finish it up.

joydeep-b commented 5 years ago

I went over this, and it seems fine, just want to confirm the use case - is the idea to specify what part of the field each line is supposed to represent? @g3force

joydeep-b commented 5 years ago

Ah, missed the conversation in the Issue. Sounds good.

joydeep-b commented 5 years ago

@g3force Feel free to merge when ready.

g3force commented 5 years ago

yeah. Right now, all the lines and arcs have standardized names, but they are encoded as strings. To find the field dimensions, you have to expect lines with certain names.

I think, the reason why I still not merged this is, that I'd like to also have some parameters directly in the protobuf structure, like field length, etc, so that teams do not need extract them from the lines.

I'll have a look at it later.

joydeep-b commented 5 years ago

We can have a redundant length field for the lines, to make it easy.

g3force commented 5 years ago

I mixed things up. I thought there is no field length and width in the protobuf, but it is. The lines should be fine as is. I'll have a more detailed look later and get this merged.

g3force commented 5 years ago

I found, what I wanted to add: The penalty area dimensions where only implicitly encoded into the lines. I added dedicated fields next to the field dimensions, so teams do not have to extract the dimensions from the lines.