joydeep-b
commented
5 years ago Perhaps as a comment in the code. Yes, good to merge.
On Fri, May 24, 2019 at 1:26 PM Nicolai Ommer notifications@github.com wrote:
@g3force commented on this pull request.
In src/app/stacks/visionstack.cpp https://github.com/RoboCup-SSL/ssl-vision/pull/133#discussion_r287450787 :
@@ -34,10 +39,26 @@ VarList * VisionStack::getSettings() { }
void VisionStack::process(FrameData * data) {
- for (auto p : stack) {
- p->lock();
- p->process(data,opts);
- p->unlock();
- if(_v_print_timings->getBool()) {
ok. Do you mean to document this somewhere? I'm not sure, where I should do this. The flag is false by default, so it must be switched on actively per camera. If this is fine for you, I would merge the PR?
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/RoboCup-SSL/ssl-vision/pull/133?email_source=notifications&email_token=AAZ7TPK54IUVLY5NUMM7NW3PXAQK3A5CNFSM4HOSCJY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZVH4AI#discussion_r287450787, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZ7TPM4S5GKNCWRV6YHXK3PXAQK3ANCNFSM4HOSCJYQ .
I added an option to print several timings of image processing. I think this will also be useful for end users if the capture rate is low, to see where the bottleneck is.
The steady clock should have nearly no impact on the performance.